New integration version available for testing

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

Cool, that helps! Smile

I think I prefer to do the filtering as I posted before because it does not mess up the item count per page (which will look like a bug, imho) and saves resources by not having to fetch objects that will not be used.

Code: › Find:
// Subtract the albumItemIds from the childItemIds
$itemIds = array_diff($childItems, array_keys($idMap));

Replace With:
$itemIds = array();

if (sizeof($childItems))
{
$query = 'SELECT [GalleryEntity::id] FROM [GalleryEntity] WHERE [GalleryEntity::entityType] = ? AND [GalleryEntity::id] IN (' . implode(',', $childItems) . ')';
list ($ret, $searchResults) = $gallery->search($query, array('GalleryPhotoItem'));
if ($ret) {
echo 'Problem!';
}

while ($result = $searchResults->nextResult()) {
$itemIds[] = $result[0];
}
}

So, the rest is view source and resize permissions? I'll have to work through it - still a lot to wade through.
Razz

AdBot

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 129

I don't know the database query way is better or not, in terms of memory usage and server loading.
I do know my mods eats up more memory and most of the time, not pretty Razz

As I said: I'm not programmer...... yet, still a long way to become one.

Just fix the preview option url, here is the changes:

g2is.html

find:

Code: › <a href="{g2is_thumbs.THUMB_LINK}" rel="lightbox" title="{g2is_thumbs.LB_TITLE}"><img src="templates/subSilver/images/g2is/magnifier.gif" alt="" title="{L_G2IS_VIEWLGR}" /></a>

replace with:

Code: ›                
               <a href="{g2is_thumbs.THUMB_LINK}" rel="lightbox" title="{g2is_thumbs.LB_TITLE}"><img src="templates/subSilver/images/g2is/magnifier.gif" alt="" title="{L_G2IS_VIEWLGR}" /></a>

g2is.php

find:

Code: › $index = 't';
list ($s_hidden_data, $void) = buildOptions($id, $index, $thumbnail[$id], $urlGenerator, true);

add after:

Code: ›
$thumb_link = '';

find:

Code: ›             list ($s_hidden_data, $options) = buildOptions($id, $index, $resizes[$id][$i], $urlGenerator);
            $size_options .= $options;
         }

add after:

Code: ›
$thumb_link = $urlGenerator->generateUrl(array('view' => 'core.DownloadItem', 'itemId' => $resizes[$id][0]->getId()), array('forceFullUrl' => true, 'forceSessionId' => false));

find:

Code: › 'THUMB_LINK' => $urlGenerator->generateUrl(array('view' => 'core.DownloadItem', 'itemId' => $itemObject->getId()), array('forceFullUrl' => true, 'forceSessionId' => false)),

replace with:

Code: › 'THUMB_LINK' => $thumb_link,

Preview now shows the first resizes instead of original, hides if current user only have core.view permission.

BTW, Back port G2IS to phpbb2 is in full function by now, with guest view mode / user view mode in config section.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

I've been playing around with gallery permissions and I'm not sure all of this is even worth it. First, your system is flawed because it only really works on an album basis and not an individual item basis. I can set an album to view all permission and then set items within that album to view item permission and your scheme breaks down. In order to fully implement this it seems like it is going to take a lot more code and a lot more js code and I just don't think it is worth it at all.

The only permission all this seems to affect is the view item permission. Setting to anything else other than view all versions makes the items disappear from the list anyway by gallery's own permission checking.

I think it is better to keep things simple and light, the way it is. The size limit of a posted image can be controlled by phpBB anyway, so I don't see the point of worrying about the original or resized images from the image selector.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

All that is affected by all this are albums/items with "view item" permission. Items with "view all versions" don't have a problem (obviously) and any other view permission settings result in the album/item not being shown at all in the image selector.

I'm thinking a better way to handle this issue might be to note items that have limited insert options when they are shown in the image selector and then if an invalid insert option is selected, have a js alert popup that says the combination of insert options is not possible and explain the options. A few lines of js code and little changes to the php code - much simpler!

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 129

Current code for preview get the original url

Code: › $urlGenerator->generateUrl(array('view' => 'core.DownloadItem', 'itemId' => $itemObject->getId()), array('forceFullUrl' => true, 'forceSessionId' => false))

most likely, original sizes will be larger than the 600x600 G2IS window.
So, it is logical to change that to the smallest resizes which might be viewable in full with in the G2IS window and make preview useful.

Permission handling by test [core.viewAll] is simpler, indeed. But [core.viewSource], [core.viewResizes] also needed to test for generate correct urls.

Summary, related to permission of G2IS (without my mods) :

GalleryCoreApi::fetchAlbumTree()

return albums visible by current user, handle correctly.
GalleryCoreApi::fetchChildItemIds()

return items visible by current user, handle correctly.
GalleryCoreApi::fetchThumbnailsByItemIds()

GalleryCoreApi::fetchChildItemIds() already passed visible items, always correct.
GalleryCoreApi::fetchResizesByItemIds()

return resizes, without permission check.
Original url generation.

Code: ›    // Build options for the original image
   $index = 0;
   list ($s_hidden_data, $size_options) = buildOptions($itemObject->getId(), $index, $itemObject, $urlGenerator, true);

return original url, without permission check.
Preview url

mentioned above.
BBcode options

no checking for valid options.

To handle mixed item permission correctly in efficient way, is out of my programing ability Razz

The mods posted so far is just my input for solving the permission issue, take your time to get the code updates which honors Gallery item view permissions.

Web Hosting India