Upgrade instructions (0.5.10 to 0.5.11)

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1050

I have a new set of files if it helps identify lingering issues. Smile

I guess that means there is a version 0.5.12 now.

Here is the changelog I have so far...

Code: › 2008-03-14 Dariush Molavi <dari@nukedgallery.net> 0.5.12
* Fix: Changed template_mods.txt to subSilver_mods.txt so README is correct.
* Fix: Added missing copy line for admin/gallery2_unmap.php in
   integration_mods.txt.
* Fix: Removed the $db->sql_freeresult($result); line from
   includes/usercp_viewprofile.php in integration_mods.txt.
* Fix: FIND instruction in subSilver_mods.txt.
* Fix: sql statement in admin_gallery2.php so initial setup runs properly
   with empty phpbb_gallery2 table.
* Fix: FIND instruction in lightbox_mods.txt so lightbox now works in
   posting preview.
* Fix: Added mod instructions to lightbox_mods.txt so lightbox now works in
   viewtopic.
* Fix: Added to lightbox_mods.txt per phpBB3 mods so lightbox "loading" and
   "close" icons now work.
* Fix: Added lightbox_overrides.css file per phpBB3 mods so lightbox "prev"
   and "next" icons now work.
* Thanks to PoPoutdoor for help in identifying and fixing the majority of
   these issues.

Quote: › 1. FIX initial gallery2 integration config issue:

That is the only thing I had a problem with, but it only happens with a clean install and empty gallery2 table. That's why I didn't see it before.

Quote: › 2. Lightbox mod

There was still a problem with viewtopic, so I had to add some more mod code. The js stuff only needs to go in overall_header.tpl. Here is the mod file I have that is working on mine:

Code: › ##############################################################
## MOD Title: Gallery2 Integration Mod
## MOD Author: jettyrat <jettyrat@jettyfishing.com> (Scott Gregory) http://jettyfishing.com
## MOD Description: This mod integrates phpBB2 and Gallery2. See the Readme.
## MOD Version: 0.5.12
##
## Installation Level: Intermediate
## Installation Time: 10 Minutes
## Files To Edit: includes/bbcode.php,
## includes/page_header.php,
## includes/viewtopic.php,
## templates/subSilver/bbcode.tpl,
## templates/subSilver/overall_header.tpl,
## Included Files: templates/subSilver/lightbox_overrides.css
## License: http://opensource.org/licenses/gpl-license.php GNU General Public License v2
##############################################################
## Author Notes: Support for this mod can be found at http://www.nukedgallery.net
##
##############################################################
## MOD History: See ChangeLog
##
##############################################################
## Before Adding This MOD To Your Forum, You Should Back Up All Files Related To This MOD
##############################################################
#
#-----[ COPY ]------------------------------------------
#
copy phpBB2/templates/subSilver/lightbox_overrides.css to templates/subSilver/lightbox_overrides.css

#
#-----[ OPEN ]------------------------------------------
#
includes/bbcode.php

#
#-----[ FIND ]------------------------------------------
#
$bbcode_tpl['url4'] = str_replace('{URL}', 'http://\\1', $bbcode_tpl['url']);
$bbcode_tpl['url4'] = str_replace('{DESCRIPTION}', '\\3', $bbcode_tpl['url4']);

#
#-----[ AFTER, ADD ]------------------------------------------
#
$bbcode_tpl['lburl'] = str_replace('{LBURL}', '\\1', $bbcode_tpl['lburl']);
$bbcode_tpl['lburl'] = str_replace('{DESCRIPTION}', '\\2', $bbcode_tpl['lburl']);

#
#-----[ FIND ]------------------------------------------
#
// [url=www.phpbb.com]phpBB[/url] code.. (no xxxx:// prefix).
$patterns[] = "#\[url=((www|ftp)\.[\w\#$%&~/.\-;:=,?@\[\]+]*?)\]([^?\n\r\t].*?)\[/url\]#is";
$replacements[] = $bbcode_tpl['url4'];

#
#-----[ AFTER, ADD ]------------------------------------------
#
// g2image [lburl=xxxx://www.phpbb.com]phpBB[/lburl] code..
$patterns[] = "#\[lburl=([\w]+?://[\w\#$%&~/.\-;:=,?@\[\]+]*?)\]([^?\n\r\t].*?)\[/lburl\]#is";
$replacements[] = $bbcode_tpl['lburl'];

#
#-----[ FIND ]------------------------------------------
#
$text = preg_replace($patterns, $replacements, $text);

// Remove our padding from the string..

#
#-----[ BEFORE, ADD ]------------------------------------------
#
if (strpos($text, 'lburl') && !defined('LBURL')) {
   define('LBURL', true);
}

#
#-----[ OPEN ]------------------------------------------
#
includes/page_header.php

#
#-----[ FIND ]------------------------------------------
#
$template->assign_vars(array(

#
#-----[ BEFORE, ADD ]------------------------------------------
#
if (defined('LBURL')) {
$template->assign_block_vars('switch_enable_lightbox', array());
}

#
#-----[ FIND ]------------------------------------------
#
$template->pparse('overall_header');

#
#-----[ REPLACE WITH ]------------------------------------------
#
if (!$in_viewtopic)
{
$template->pparse('overall_header');
}

#
#-----[ OPEN ]------------------------------------------
#
includes/viewtopic.php

#
#-----[ FIND ]------------------------------------------
#
$page_title = $lang['View_topic'] .' - ' . $topic_title;
include($phpbb_root_path . 'includes/page_header.'.$phpEx);

#
#-----[ BEFORE, ADD ]------------------------------------------
#
$in_viewtopic = true;

#
#-----[ FIND ]------------------------------------------
#
   $message = ($board_config['allow_bbcode']) ? bbencode_second_pass($message, $bbcode_uid) : preg_replace("/\:$bbcode_uid/si", '', $message);

#
#-----[ BEFORE, ADD ]------------------------------------------
#
   if (strpos($message, 'lburl')) {
      $template->assign_block_vars('switch_enable_lightbox', array());
   }

#
#-----[ FIND ]------------------------------------------
#
$template->pparse('body');

#
#-----[ BEFORE, ADD ]------------------------------------------
#
$template->pparse('overall_header');

#
#-----[ OPEN ]------------------------------------------
#
templates/subSilver/bbcode.tpl

#
#-----[ FIND ]------------------------------------------
#
<a href="{URL}" target="_blank" class="postlink">{DESCRIPTION}</a>

#
#-----[ AFTER, ADD ]------------------------------------------
#
<a href="{LBURL}" class="postlink" rel="lightbox[g2image]">{DESCRIPTION}</a>

#
#-----[ OPEN ]------------------------------------------
#
templates/subSilver/overall_header.tpl

#
#-----[ FIND ]------------------------------------------
#


#
#-----[ BEFORE, ADD ]------------------------------------------
#

<script type="text/javascript" src="./g2image/jscripts/prototype.js"></script>
<script type="text/javascript" src="./g2image/jscripts/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="./g2image/jscripts/lightbox.js"></script>
<script type="text/javascript">
fileLoadingImage = "./g2image/images/loading.gif";
fileBottomNavCloseImage = "./g2image/images/closelabel.gif";
</script>
<link rel="stylesheet" href="./g2image/css/lightbox.css" type="text/css" media="screen" />
<link rel="stylesheet" type="text/css" href="templates/subSilver/lightbox_overrides.css" />


#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM

Replace all the < with < and the > with >

Quote: › 3. g2helper.inc, mapAllGalleryLinks function code

I think the function only for "user gallery / gallery link in profile" mods

That's right.

Quote: › About lightbox:

My fix only good at preview and viewtopic, BUT the image path errors when g2Image popup.

1. How to fix the path issue?
2. No error message about image access rights, such as Guest not allow to view full size image.
3. Does lightbox support selecting resized image?
4.Gallery is embed only, lburl not works if I changed the generated path from ./gallery2/main.php to ./gallery2.php

1. I don't have a path issue, so not sure what you mean!
2. I have not tried experimenting with permissions and access restrictions so not sure. I would think that if g2image is using the imageblock module that permissions are respected, but not sure about the image link generated in the bbcode. Will have to look into that some time.
3. You mean g2image? That is supposed to be included in the next release of g2image, but currently it does not support resized images.
4. I'm not following that one. What needs changing?

AdBot · Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

Quote: › 1. I don't have a path issue, so not sure what you mean!

I think your update can fix that path error, related to g2Image popup window. Have to wait for 0.5.12 release first. Smile

Quote: › 4. I'm not following that one. What needs changing?

Sorry for not express that well...

When G2 URL_REWRITE enabled, bbcode generated by g2Image no longer in

Quote: › "http://www.domain.tld/g2path/main.php?..."

format, changed to something like

Quote: › "http://www.domain.tld/%path%/..."

Thanks for your quick response!

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

About g2image:

g2image supposed to let user select photo which links to G2.

For the user interface part, I don't think that needs Lightbox for the selection, thumbnail only will be straight forward for the selection.

If take out the LightBox part, functionality stay intact and we don't need extra code to fix the popup window path issue.

If user do need a bigger size preview of the selection, can borrow code from the G2 photo deletion function.

Just my 2 cents Smile

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1050

You can always not install the lightbox mods if you don't want it and remove the selection in g2image.

You are free to develop more for the integration if you would like! Smile

I wish someone would take it over actually since my interest is in phpbb3 now!

Do you want to try the latest files and make sure there are no other problems with them?

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

I'm not going to upgrade phpBB3 soon...

I would like to take up, but I'm only good at fixing small bugs and write some lines of php.

Anyway, I can work on fixing current code and post updates here Smile

BTW, I try your lightbox mod code (without the image path fix for g2image popup) and found viewtopic generate 2 instance of lightbox code block.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1050

Where are the two instances of the code block - in the page source? Mine doesn't have this problem. Are you sure you don't have double mods somewhere - overall_header.tpl?

I noticed an issue in the lightbox mods - this:

Code: › <a href="{LBURL}" class="postlink" rel="lightbox[g2image]">{DESCRIPTION}</a>

Should be:

Code: › <a href="{LBURL}" class="postlink" rel="lightbox[g2image]">{DESCRIPTION}</a>

(should end with lburl)

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

Upgrade instructions updated, summary:

1. Add G2 url_rewrite support to bbcode.php.

Code: › #
#-----[ FIND ]----------------------------------
#
// [img]image_url_here[/img] code..
$text = preg_replace("#\[img\]((http|ftp|https|ftps)://)([^ \?&=\#\"\n\r\t<]*?(\.(jpg|jpeg|gif|png)))\[/img\]#sie", "'[img:$uid]\\1' . str_replace(' ', '%20', '\\3') . '[/img:$uid]'", $text);
#
#-----[ BEFORE, ADD ]-----------------------------
#
// g2image - G2 url rewrite support(for [img]...[/img] tags)
$text = preg_replace('((\?)(g2_GALLERYSID=[a-f0-9]+|g2_GALLERYSID=TMP_SESSION_ID_DI_NOISSES_PMT))', '', $text);

2. Remove Lightbox features from g2image popup window

Code: › #
#-----[ OPEN ]------------------------------------------
#
g2image/g2image.php

#
#-----[ FIND ]------------------------------------------
#
. ' </div>' . "\n"

// "LightBox Group" textbox

. ' <div name="lightbox_group_textbox"';

if ($g2ic_options['default_action'] == 'thumbnail_lightbox'){

$html .= ' class="displayed_textbox"';

}

else {

$html .= 'class="hidden_textbox"';

}

$html .= '>' . "\n"

. ' <label for="lightbox_group">' . T_('LightBox Group (Leave blank to not group with other images)') . '<br /></label>' . "\n"

. ' <input type="text" name="lightbox_group" size="84" maxlength="150" value="g2image" />' . "\n"

. ' <br />' . "\n"

. ' <br />' . "\n"

. ' </div>' . "\n";

#
#-----[ REPLACE WITH ]----------------------------
#
. ' </div>' . "\n";

// "LightBox Group" textbox

// code block removed
#
#-----[ FIND ]------------------------------------------
#

$html .= ' <label for="alignment">' . T_('G2Image Alignment Class') . '</label>' . "\n"

. g2ic_make_html_alignment_select()

. " </fieldset>\n\n";

#
#-----[ REPLACE WITH ]----------------------------
#
// code block removed

#
#-----[ FIND ]------------------------------------------
#
. ' <link rel="stylesheet" href="css/lightbox.css" type="text/css" />' . "\n"
#
#-----[ REPLACE WITH ]----------------------------
#
# delete line, or:
. ' ' . "\n"
#
#-----[ FIND ]------------------------------------------
#
. ' <script language="javascript" type="text/javascript" src="jscripts/prototype.js"></script>' . "\n"

. ' <script language="javascript" type="text/javascript" src="jscripts/scriptaculous.js?load=effects"></script>' . "\n"

. ' <script language="javascript" type="text/javascript" src="jscripts/lightbox.js"></script>' . "\n"

#
#-----[ REPLACE WITH ]----------------------------
#
# delete lines, or:
. ' ' . "\n"

. ' ' . "\n"

. ' ' . "\n"

#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM

3. Lightbox features Mods

Customized, only for viewtopic page.
(the lightbox related javascripts conflicts with MultiBBcode mode, I have to remove that to get my posting page javascripts works again)

gondee · Novice Joined: Apr 15, 2006 Posts: 20

I've been installing/uninstalling this a few times with my test board and I've run into a few issues after installing it on my main board. I'm hoping you can two can clear these bugs up (thanks for tackling this PoPoutdoor - I know Jetty's busy tackling phpBB3 stuff.) These bugs do not include the fixes here - I'm not sure which ones I should definitely implement. Embarassed

Why Switches around Lightbox Scripts?
In the install directions for the lightbox it says :
(I'm changing the greater than/less than signs in this post to brackets because the board won't let me post the code as it is in the install directions.)

Code: › [!-- BEGIN switch_enable_lightbox --]
[script type="text/javascript" src="./g2image/jscripts/prototype.js"] [/script]
[script type="text/javascript" src="./g2image/jscripts/scriptaculous.js?load=effects"][/script]
[script type="text/javascript" src="./g2image/jscripts/lightbox.js"][/script]
[link rel="stylesheet" href="./g2image/css/lightbox.css" type="text/css" media="screen" /]
[!-- END switch_enable_lightbox --]

However, as far as I can tell, there is no option in the Admin panel anywhere that lets you turn off lightbox, no "switch_enable_lightbox" option. I had to remove the switches in order to get the lightbox option on the g2image feature to work. Is this option missing - why are there switches on this code?

g2Image Thumbnails disappear if you edit your post sometime later
Also, it seems that if you use the lightbox option in g2image and then go back and edit your original post sometime later, the g2image thumbnails revert back to normal [lburl] codes and no thumbnails are displayed. I guess that might have something to do with the session codes that are included, but it's a bug I noticed when I went back and edited a post where I explained how to use the new features on my board.

Take a look at those "bugs" if you are looking for more bug reports.

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

gondee,

To be honest, I'm not a programmer. For two years of maintaining 3 phpBB2 sites(1 is phpBBplus), I learned some tricks on applying and fixing mods.

I didn't make "Gallery Profile Mod / All Gallery Links In Profile Mod" works in 0.5.10 and 0.5.11 for my last mod test. I will test that part again later on.

1. About Lightbox mod:

- 0.5.11 package doesn't have options to disable Lightbox features.
- If you don't want to use Lightbox, skip the lightbox mods.
- the template switch code output ONLY if you have the [lburl]...[[/lburl] tags in post message.

2. g2Image in post:

Agrees with the "session" guess, but I didn't noticed missing thumbnail display.
I will take closer look at the code. hope I can find some useful info there.

Meanwhile, I'm working on remove Lightbox features from g2image popup window, take a look on my upgrade instructions on first post.

gondee · Novice Joined: Apr 15, 2006 Posts: 20

That's okay Popoutdoor - I'm pretty much the same as you are in that regard. You seem to understand more about PHP than I do though.

Sorry guys, I was instituting some bugfixes here when the whole thing went to hell and even my backup files wouldn't work. I edited my message above to remove all the examples from my site as the integration is not installed there anymore. I had to backup to before I started the install - I'm going to give it one last try tomorrow night and if that doesn't work I'm going to uninstall the whole thing. My board is so heavily modded I think it might be unfair to expect you guys to fix all my problems. Smile

Thanks for the help PoPoutdoor. Smile

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

I'm testing the "cleanup" version of g2image by now.
If everything seems OK, I'll post update here soon.

gondee,

I'm a computer user back to the DOS era Wink

And now, my home networks is Linux only Smile

Before my friend ask me to setup his personal site, I don't even know php exists Razz

Besides of code sharing, I think opensource spirit encourage self-learning too Wink

The facts from daily apache log, I have to catch up every new tricks before my server got hacked!

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

Instructions for g2Image code cleanup updated on first post.

Lightbox issue:

With mouse click on the "close" button, righthand side shown the up & down arrows on firefox.
Any idea?

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1050

I thought you said you were no programmer!

I may implement your preg expression to cut out the g2 session id in g2image links in the phpbb3 integration as well. Smile

Just curious why you cut up the g2image code so much? The idea was to leave as a drop-in for future upgrades of the g2image code and the references to word press and drupal aren't really hurting anything by being in there.

PoPoutdoor · Wizard Joined: Jan 20, 2006 Posts: 109

jettyrat,

I can write some lines of code doesn't mean I'm as smart as you guys. Creating something like the G2 integration package needs more skills that I may never achieved.

Quote: › Just curious why you cut up the g2image code so much?

The short answer: I only have phpbb2.

The long answer: The g2image package is too complicated for me to trace. Just commented out code I can't follows. After the cleanup, I start adding code for the resized image.

For g2image, I think current code should changed to more modular way, which loads only those javascripts as needed.

Good new: My test g2image code now returns resized image url for lightbox. I'm going to add resized selection to g2image.

Some help needed: How to deal with the Language part?

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1050

Quote: › I can write some lines of code doesn't mean I'm as smart as you guys. Creating something like the G2 integration package needs more skills that I may never achieved.

Yeah well, that's how it starts! Smile

I'd be interested in your changes for the re-sized image. The next version of g2image is supposed to include this also.

Quote: › Some help needed: How to deal with the Language part?

Try this: http://www.poedit.net/ [poedit.net] I have not tried it myself, but it turned up on google search as possibility.