About there

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

I think the integration is about there now. Spent the past couple days working on icons, css, templates and related code trying to make the integration look right in prosilver. There are still some things I would like to see done, but none of them are stopping the integration from being tested by any brave souls wishing to do so. The viewtopic, memberlist view, profile view, image selector, embedded gallery all seem to be working.

To do list:
1. Further function testing
2. Installation instructions (readme.html)
3. Form check boxes in embedded gallery (possibly other css issues...likely nasty to fix)
4. Integration with subsilver2 and the other gallery themes
5. Multi-language capability (hopefully this is fixed now that phpbb3 and gallery2 both use utf-8 encoding)
6. Testing of sub-domain installs (eg. phpbb3.mysite.com and gallery.mysite.com - some have gotten this to work in the past and some have not)
7. Testing of aliased sub-domain installs (eg. the web server aliases different directory paths to sub-domain names - some have gotten this to work in the past and some have not)
8 Testing of the url rewrite module (some have gotten this to work in the past and some have not)
9. Gallery admin permissions in the phpbb3 acp (this was originally planned in the first olympus integration, but never fully worked and subsequent phpbb3 code changes led to the abandonment of it - eg. 2 admins in phpbb3, 1 has gallery settings access, 1 does not)
10. More automated config script to reduce user installer interaction and reduce a LOT of configuration problems at install time (requires code writing)
11. Better implementation of the gallery embed discovery class
12. An installer script to automate the entire integration (requires a lot of code writing)

Probably more....let me know....

AdBot

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

BTW, only the first 3 or 4 items need to be addressed soon, the rest are wish list items. None are stopping anyone from applying the integration if they are up to speed with how to use it.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Finally got #3 on the list above tackled after a couple hours of detective work. Turns out phpbb3 uses gallery in it's css to define the avatar gallery attributes. Obviously gallery2 uses gallery in it's css to define various attributes. This causes at least one conflict I've seen so far. Easily fixed by adding another mod to the gallery theme css to override the phpbb setting. Also requires the gallery css be loaded after the phpbb3 css so the change can take effect. I don't think there is a case where the phpbb avatar gallery will be displayed at the same time as the photo gallery, so shouldn't cause other issues.

Only really leaves the readme instructions to rewrite for a new release.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Also added a module check to the image selector so if the imageblock module is not installed and activated in gallery you will get an error message now instead of it just not working.

timnsal · Novice Joined: Aug 08, 2007 Posts: 25

I'm still getting exactly the same thing with the form checkboxes. I'll check again if I've missed anything.

Some of the functions in includes/functions_user.php don't have $phpbb_root_path defined - group user add and user delete, I think. Once you define the path, they seem to be working now.

Well done

Sally

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Sally, these are the changes for the form checkboxes in gallery that work on mine.

Code: › #
#-----[ OPEN ]------------------------------------------
#
gallery2/themes/matrix/local/theme.css

#
#-----[ FIND ]------------------------------------------
#
#gsThumbMatrix .giRatingAverageContainer {
margin: auto;
}

#
#-----[ AFTER, ADD ]------------------------------------------
#
/* ********************************************************************************
* fix for phpBB3 embedded Gallery
*/
#gallery label {
position: static;
float: none;
margin: 0px;
padding: 0px;
border: none;
}

And make sure the gallery css is loaded after the phpbb css in overall_header.html

Code: › #
#-----[ OPEN ]------------------------------------------
#
styles/prosilver/template/overall_header.html

#
#-----[ FIND ]------------------------------------------
#

<link href="{T_THEME_PATH}/bidi.css" rel="stylesheet" type="text/css" media="screen, projection" />


#
#-----[ AFTER, ADD ]------------------------------------------
#
{GALLERY2_CSS}
{GALLERY2_JAVASCRIPT}

This is different than the previous mods.

You might also need to clear the browser cache and delete the phpbb/cache directory to force the changes. Let me know if it still does not work. Which page is it that is broken?

Thanks for pointing out the phpbb_root_path issue! I'll look into it...

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Here is mine...

before

after

IngerK · Wizard Joined: Jan 19, 2006 Posts: 74

I have just installed the integration pack, works so far, but I will have to test more Very Happy

I use rewrite, and I had to edit a couple of files [nukedgallery.net] to get it to work. Rewrite seems to work for me now. I found this in the integration-pack for phpBB2.

timnsal · Novice Joined: Aug 08, 2007 Posts: 25

Thanks. I'd missed the change to overall_header.html Embarassed

Works fine now.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

IngerK, what was the problem with the url rewrite? Similar to this http://www.nukedgallery.net/postt2911.html [nukedgallery.net] with the broken relative links in phpbb?

One reason I left it out of this integration is that it can cause problems with aliased directories as in http://www.nukedgallery.net/postt3359.html [nukedgallery.net]

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Guess these are my thoughts on this:
If you use the url rewrite module, you will have to add the changes for the base tag, however, if you use or are forced to use aliased server directories the base tag will foul up the integration and therefore you can't use the url rewrite module.

Another one for the installation file...

IngerK · Wizard Joined: Jan 19, 2006 Posts: 74

Yes, I think it is the same problem. Two screenshots, the first is without the file-edits I mentioned, the second is with the edits in gallery2.php and overall_header.html:

http://www.cactuz.org/inger/files/testgal1.png
http://www.cactuz.org/inger/files/testgal2.png

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Yes, that's the same problem as the phpbb2 integration. I will try to make sure it is noted in the installation file. Thanks for pointing it out!

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1047

Big thanks to Sally for hammering away on the functions testing! Very Happy

timnsal · Novice Joined: Aug 08, 2007 Posts: 25

Still some hiccoughs with the user and group functions. I'll test a bit and try to recreate exactly what I did.