Improved random block :fixed the block-random.cacheerror

myrtul · Beginner Joined: Jul 11, 2003 Posts: 1

Ok.. hard times to find :
i had to delete the block-random.cache file after changing the ALBUM_BASEADDR variable.
then i had the same errors i saw in some post:
Warning: Invalid argument supplied for foreach() in /home/*******/public_html/BlackNova/html/modules/gallery/random_support.php on line 230
etc etc

i found that the test in get_random_photo_id() function is wrong

Code: › $rebuild = 0;
   if (fs_file_exists(CACHE_FILE)) {
      $stat = fs_stat(CACHE_FILE);
      $mtime = $stat[9];
      if (time() - $mtime < CACHE_EXPIRED) {
      $rebuild = 1;
      }
   }

   if ($rebuild) {
      scanalbums();
      savecache();
   } else {
      readcache();
      print "readcache";
   }

should be

Code: › $rebuild = 0;
   if (fs_file_exists(CACHE_FILE)) {
      $stat = fs_stat(CACHE_FILE);
      $mtime = $stat[9];
      if (time() - $mtime < CACHE_EXPIRED) {
      $rebuild = 1;
      }
   }

   if (!$rebuild) {
      scanalbums();
      savecache();
   } else {
      readcache();
      print "readcache";
   }

in the first one , it tries to read the cache file if it does not exists!

PS: if this bug has already been notified , i m sorry .. i havent found a post with it

AdBot

dari · Posted: Sat Jul 12, 2003 9:55 am Post subject:

hmm...yeah, i'll patch it up and reissue a new download later this weekend. thanks for the note Smile

_________________

yrret · Beginner Joined: Apr 19, 2003 Posts: 3

DELETE YOUR OLD block-random.cache file, and you will not get the out of bounds etc error, or the rand() errors.
Jeez, I was ready to shoot myself in the head.

dari

an updated version, with this fix, is available in the downloads section.
_________________