#
#-----[ COPY ]----------------------------------
#
copy phpBB2/lang_convert.class to lang_convert.class
copy phpBB2/admin/gallery2_export.php to admin/gallery2_export.php
copy phpBB2/g2image/g2image.php to g2image/g2image.php
copy phpBB2/g2image/gettext.inc to g2image/gettext.inc
copy phpBB2/g2image/gettext.php to g2image/gettext.php
copy phpBB2/g2image/init.php to g2image/init.php
copy phpBB2/g2image/streams.php to g2image/streams.php
copy phpBB2/g2image/css/dtree.css to g2image/css/dtree.css
copy phpBB2/g2image/css/g2image.css to g2image/css/g2image.css
copy phpBB2/g2image/css/lightbox.css to g2image/css/lightbox.css
copy phpBB2/g2image/images/ to g2image/images/
copy phpBB2/g2image/img to g2image/img
copy phpBB2/g2image/jscripts/dtree.js to g2image/jscripts/dtree.js
copy phpBB2/g2image/jscripts/effects.js to g2image/jscripts/effects.js
copy phpBB2/g2image/jscripts/functions.js to g2image/jscripts/functions.js
copy phpBB2/g2image/jscripts/lightbox.js to g2image/jscripts/lightbox.js
copy phpBB2/g2image/jscripts/prototype.js to g2image/jscripts/prototype.js
copy phpBB2/g2image/jscripts/scriptaculous.js to g2image/jscripts/scriptaculous.js
copy phpBB2/g2image/langs/ to g2image/langs/
copy phpBB2/language/lang_english/lang_gallery2.php to language/lang_english/lang_gallery2.php
#
#-----[ OPEN ]----------------------------------
#
includes/bbcode.php
#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM
Step 4: Remove Lightbox features from g2image popup window(also remove code that not working on phpbb2)
Code: › #
#-----[ OPEN ]----------------------------------
#
g2image/g2image.php
#
#-----[ FIND ]----------------------------------
#
if ($g2ic_options['wpg2_valid']) echo g2ic_make_html_wpg2_album_insert_button();
if ($g2ic_options['drupal_g2_filter']) echo g2ic_make_html_drupal_album_insert_button();
#
#-----[ REPLACE WITH ]----------------------------
#
# or delete
// Removed for phpBB2
//if ($g2ic_options['wpg2_valid']) echo g2ic_make_html_wpg2_album_insert_button();
//if ($g2ic_options['drupal_g2_filter']) echo g2ic_make_html_drupal_album_insert_button();
#
#-----[ FIND ]----------------------------------
#
// If using the WPG2 or Drupal Gallery Module append '(HTML)' to the end of the universal messages
if ($g2ic_options['wpg2_valid'] || $g2ic_options['drupal_g2_filter']) {
foreach($message as $key => $text) {
$message[$key] = $text . ' (' . T_('HTML') . ')';
}
}
// These are CMS-specific image insertion options
$message['wpg2_image'] = T_('WPG2 tag of image');
$message['drupal_g2_filter'] = T_('Drupal Gallery2 Module filter tag');
#
#-----[ REPLACE WITH ]----------------------------
#
# or delete
// Removed for phpBB2
/*
// If using the WPG2 or Drupal Gallery Module append '(HTML)' to the end of the universal messages
if ($g2ic_options['wpg2_valid'] || $g2ic_options['drupal_g2_filter']) {
foreach($message as $key => $text) {
$message[$key] = $text . ' (' . T_('HTML') . ')';
}
}
#
#-----[ REPLACE WITH ]----------------------------
#
# or delete
/**
* Creates the alignment selection HTML
*
* @return string $html The alignment selection HTML
*/
// Removed for phpBB2
/*
function g2ic_make_html_alignment_select(){
GLOBAL $g2ic_options;
*/
#
#-----[ FIND ]----------------------------------
#
/**
* Creates the HTML for inserting an album Drupal Filter Tag
*
* @return string $html The HTML for for inserting an album Drupal Filter Tag
*/
function g2ic_make_html_drupal_album_insert_button(){
GLOBAL $g2ic_options, $g2ic_album_info, $g2ic_gallery_items;
$html = '';
// Create the form
$html .= "<div>\n"
. " <fieldset>\n"
. ' <legend>' . T_('Insert a Drupal G2 Filter tag for the current album:') . ' ' . $g2ic_album_info['title'] . '</legend>' . "\n";
return $html;
}
#
#-----[ REPLACE WITH ]----------------------------
#
# or delete
/**
* Creates the HTML for inserting an album Drupal Filter Tag
*
* @return string $html The HTML for for inserting an album Drupal Filter Tag
*/
// Removed for phpBB2
/*
function g2ic_make_html_drupal_album_insert_button(){
GLOBAL $g2ic_options, $g2ic_album_info, $g2ic_gallery_items;
$html = '';
// Create the form
$html .= "<div>\n"
. " <fieldset>\n"
. ' <legend>' . T_('Insert a Drupal G2 Filter tag for the current album:') . ' ' . $g2ic_album_info['title'] . '</legend>' . "\n";
// Create the form
$html .= "<div>\n"
. " <fieldset>\n"
. ' <legend>' . T_('Insert a WPG2 tag for the current album:') . ' ' . $album_info['title'] . '</legend>' . "\n";
return $html;
}
#
#-----[ REPLACE WITH ]----------------------------
#
# or delete
/**
* Creates the HTML for inserting an album WPG2 Tag
*
* @return string $html The HTML for for inserting an album WPG2 Tag
*/
// Removed for phpBB2
/*
function g2ic_make_html_wpg2_album_insert_button(){
GLOBAL $g2ic_options, $g2ic_gallery_items;
$html = '';
// Create the form
$html .= "<div>\n"
. " <fieldset>\n"
. ' <legend>' . T_('Insert a WPG2 tag for the current album:') . ' ' . $album_info['title'] . '</legend>' . "\n";
Posted: Mon Mar 03, 2008 3:10 pm Post subject: Re: Request Upgrade instructions (0.5.10 to 0.5.11)
Last weekend, I spare some time working on the 0.5.11 package... very disappointed!
1. Package doesn't have ALL the files for a new installation.
2. Mod instructions incorrect at somewhere (I can't recall all the details after fixing my site for the upgrade).
3. integration_mods.txt, includes/usercp_viewprofile.php code generate errors on
Code: › }
}
$db->sql_freeresult($result);
if (!empty($profiledata['link']))
{
$gallery_uri = append_sid("gallery2.$phpEx?g2_view=core.ShowItem&g2_itemId=" . $profiledata['user_gallery']);
Comment Line $db->sql_freeresult($result); fix the error.
4. Missing mod instructions for templates
IMHO, this package should be mark as beta.
Edit: I can't post my upgrade instructions! Message like "html not allow..." block the posting...
Posted: Mon Mar 03, 2008 5:19 pm Post subject: Re: Request Upgrade instructions (0.5.10 to 0.5.11)
@1. Which files? I just took a look at the package and everything seems to be there.
@2. We can't fix it if we don't know where the problem is!
@3. It looks like I made the sql query simpler and the freeresult won't work any longer. My bad
@4. template_mods.txt is there. The readme needs fixed because it says subsilver_mods.txt instead.
Put your fixes in a 'code' bbcode tag to post them.
I see a couple minor issues - nothing more
Also note that with the final release of phpbb3, I won't be doing much development on this integration any longer. I don't even have phpbb2 installed on my test machines any more.
Posted: Tue Mar 04, 2008 2:04 pm Post subject: Re: Request Upgrade instructions (0.5.10 to 0.5.11)
jettyrat:
Relax, man!
First of all, many thanks for the integration package for phpbb2.
The program code quality been good till 0.5.10. For 0.5.11. As you said, you don't have phpbb2 installed... so, not much actual tests leading to unexpected errors. That's the fact and I don't mean to blame anyone involved developing this package.
For software, most people agrees those lack of tests should be in alpha/beta state, no offense.
My personal site heavy modded, and I don't have the last package code.
If I got the 0.5.10 package(where can I download this?), I can try my best to create 0.5.10 to 0.5.11 upgrade instructions. May discover some minor errors for the 0.5.11 package too.
BTW, text already in [code] tags, but the site security code stops the posting, maybe catch on the template instruction lines
Posted: Tue Mar 04, 2008 5:01 pm Post subject: Re: Request Upgrade instructions (0.5.10 to 0.5.11)
No problems! The code was tested when it was written. Nothing has been reported since then, so I don't have phpbb2 installed after that, but I will install it once again with the newest version of phpbb2 and go through it one more time.
So far I only have one issue with freeresult and a typo in the readme. If there are more you can't post, feel free to email them to me- jettyrat_at_jettyfishing_dot_com.
Posted: Wed Mar 05, 2008 1:40 pm Post subject: Re: Request Upgrade instructions (0.5.10 to 0.5.11)
jettyrat,
I got the 0.5.10 package now.
I'll setup my Linux workstation with fresh phpbb2 (2.0.23) and Gallery 2.2.4 this weekend.
After 0.5.10 installed and works, I can work on the 0.5.10 to 0.5.11 upgrade instructions.
Hope I can do something useful for the integration package users.
Posted: Thu Mar 13, 2008 1:25 pm Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)
I tried the gallery link in profile mod, not working.
Maybe I'm putting the code in the wrong place(yes, I do the mods by hand)... since I'm not using this, it's OK for me.
About other issues:
1. missing [ copy ] instruction for the gallery2_unmap.php file.
2. admin/gallery2 config: Admin ID = 0 after bad mods... can't change manually.
FYI: G2 user group "Registered Users" (if my memory is good) created, but can't deleted by G2 admin user.
Suggestion: Add code to gallery2_unmap.php, for case like this.
3. Mod instructions file: splited in many files isn't good, I think the 0.5.10 way is better. Core in one mod file, add-ons into it's own will be much better, also easier for upgrade.
BTW, I will try "user gallery / gallery link in profile" mods. I wiill update instructions later on.
Posted: Thu Mar 13, 2008 5:16 pm Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)
lightbox_mods.txt
Code not works in viewtopic.php.
Fix:
1. Javascript code blocks goes to posting_preview.tpl and viewtopic_body.tpl, instead of overall_header.tpl
2. add code block to bbcode.php inside bbencode_second_pass()
Posted: Thu Mar 13, 2008 6:30 pm Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)
Ok, just spent the last couple hours installing phpbb2.0.23 and integration 0.5.11
I made these changes and everything seems to work fine:
Code: › Changed template_mods.txt to subSilver_mods.txt so README is correct.
integration_mods.txt -
Added copy line for admin/gallery2_unmap.php
Removed the $db->sql_freeresult($result); line from includes/usercp_viewprofile.php
Fixed a FIND instruction in subSilver_mods.txt
Fixed a sql statement in admin_gallery2.php
The real issues were the freeresult and sql problems. I didn't notice any missing files.
Quote: › 2. admin/gallery2 config: Admin ID = 0 after bad mods... can't change manually.
This is probably fixed with the sql change. Mine works fine.
Quote: › FYI: G2 user group "Registered Users" (if my memory is good) created, but can't deleted by G2 admin user.
Suggestion: Add code to gallery2_unmap.php, for case like this.
Registered Users is a default G2 group. It is not created by the integration and can't be deleted because it belongs there!
Quote: › 3. Mod instructions file: splited in many files isn't good, I think the 0.5.10 way is better. Core in one mod file, add-ons into it's own will be much better, also easier for upgrade.
Splitting the files was supposed to make things easier. The main files are integration_mods.txt, subSilver_mods.txt and language_mods.txt. The core integration mods are in their own file. The template mods are separate for those who use a different style and the language mods are separate for those using another language.
Quote: › I will try "user gallery / gallery link in profile" mods. I wiill update instructions later on.
These are part of the core integration now and my test installation works just fine.
The freeresult can be deleted or commented out as posted above and this sql fix make mine work just fine. (I didn't do any heavy testing, but the core integration has not changed that much.)
Open admin/admin_gallery2.php
Find:
Posted: Thu Mar 13, 2008 6:33 pm Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)
PoPoutdoor wrote: › lightbox_mods.txt
Code not works in viewtopic.php.
Fix:
1. Javascript code blocks goes to posting_preview.tpl and viewtopic_body.tpl, instead of overall_header.tpl
2. add code block to bbcode.php inside bbencode_second_pass()
Instruction updated at first post
You posted before me I didn't try the lightbox mods. I'll try them next...
Posted: Thu Mar 13, 2008 6:58 pm Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)
PoPoutdoor wrote: › lightbox_mods.txt
Code not works in viewtopic.php.
Fix:
1. Javascript code blocks goes to posting_preview.tpl and viewtopic_body.tpl, instead of overall_header.tpl
2. add code block to bbcode.php inside bbencode_second_pass()
Instruction updated at first post
No...
The problem is a missing line in the find instruction in lightbox_mods.txt. The find that says:
Code: › // Remove our padding from the string..
return substr($text, 1);
Posted: Thu Mar 13, 2008 8:59 pm Post subject: Re: Upgrade instructions (0.5.10 to 0.5.11)
Also, your upgrade instructions should say copy the new g2helper.inc file instead of editing the old one. There were some other changes to the mapAllGalleryLinks function if I remember correctly...
code mod, which goes inside bbencode_second_pass()
And the javascripts code block goes to overall_header.tpl is correct?
3. g2helper.inc, mapAllGalleryLinks function code
I think the function only for "user gallery / gallery link in profile" mods... am I wrong? (I haven't check the code, but I don't get error message about that)
I am not using "user gallery / gallery link in profile".
Maybe I'll update upgrade instructions on that later on.
About missing file:
My bad I think that related to other mods I have, and the failed upgrade drive me mad by the time I post.
About lightbox:
My fix only good at preview and viewtopic, BUT the image path errors when g2Image popup.
1. How to fix the path issue?
2. No error message about image access rights, such as Guest not allow to view full size image.
3. Does lightbox support selecting resized image?
4.After enable URL_Rewrite in G2, lburl/img not works (for g2image generated url). the mod related to bbcode.php doesn't support URL other than default.
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum