Bugs with new version

denney · Novice Joined: Dec 24, 2007 Posts: 28

I've found a couple of installation problems with v1.0.0...

In "includes/functions.php", you want to find:

Code: ›       // We do not want the cron script to be called on error messages
      define('IN_CRON', true);

      if (defined('IN_ADMIN') && isset($user->data['session_admin']) && $user->data['session_admin'])
      {
         adm_page_footer();
      }
      else
      {
         page_footer();
      }

      exit;
   break;

This should actually be:

Code: ›       // We do not want the cron script to be called on error messages
      define('IN_CRON', true);

      if (defined('IN_ADMIN') && isset($user->data['session_admin']) && $user->data['session_admin'])
      {
         adm_page_footer();
      }
      else
      {
         page_footer();
      }

      exit_handler();
   break;

You don't actually need to do this line either:

Code: › 'L_GALLERY2' => $user->lang['GALLERY2'],

phpBB will automatically use the "GALLERY2" language text.

AdBot

denney · Novice Joined: Dec 24, 2007 Posts: 28

I also recommend replacing:

Code: › 
<script type="text/javascript" src="./g2image/jscripts/prototype.js"></script>
<script type="text/javascript" src="./g2image/jscripts/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="./g2image/jscripts/lightbox.js"></script>
<link rel="stylesheet" href="./g2image/css/lightbox.css" type="text/css" media="screen" />

with:

Code: › 
<script type="text/javascript" src="{ROOT_PATH}g2image/jscripts/prototype.js"></script>
<script type="text/javascript" src="{ROOT_PATH}g2image/jscripts/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="{ROOT_PATH}g2image/jscripts/lightbox.js"></script>
<link rel="stylesheet" href="{ROOT_PATH}g2image/css/lightbox.css" type="text/css" media="screen" />

in overall_header.html in the Lightbox installation instructions.

denney · Novice Joined: Dec 24, 2007 Posts: 28

I noticed that the close and loading images for Lightbox don't display either. The problem is with the paths set in the lightbox.js file.

I fixed this by doing the following:

Removed:

Code: › var fileLoadingImage = "images/loading.gif";
var fileBottomNavCloseImage = "images/closelabel.gif";

from lightbox.js and added:

Code: › <script type="text/javascript">
// <![CDATA[
var fileLoadingImage = "{ROOT_PATH}g2image/images/loading.gif";
var fileBottomNavCloseImage = "{ROOT_PATH}g2image/images/closelabel.gif";
// ]]>
</script>

to overall_header.html in the:

Code: ›

section.

Hope you don't mind all the reports... Razz

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

Thanks! Reports are always good! Smile

I'll look at adding this to the 1.0.1 version, I want to see how the phpbb review goes first...

The first post needs to be fixed for sure, especially the find instruction. (That's probably left over from the phpbb3 beta versions)

The second is a good suggestion on the path settings.

Third is a nice fix! I've noticed the images do not work. I was trying to keep the g2image as simple as possible because it is an externally developed feature and I was trying to keep it as much of a simple drop-in as possible. Your fix is fairly simple, though.

I'll look into adding these. Thanks a lot...input appreciated! Smile

denney · Novice Joined: Dec 24, 2007 Posts: 28

Glad I could be of service mate.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

There is no need to modify the lightbox.js file if you change the code in overall_header like this...

Instead of:

Code: › // <![CDATA[
var fileLoadingImage = "{ROOT_PATH}g2image/images/loading.gif";
var fileBottomNavCloseImage = "{ROOT_PATH}g2image/images/closelabel.gif";
// ]]>

Use this:

Code: › // <![CDATA[
fileLoadingImage = "{ROOT_PATH}g2image/images/loading.gif";
fileBottomNavCloseImage = "{ROOT_PATH}g2image/images/closelabel.gif";
// ]]>

This simply sets the vars to new values and leaves lightbox.js the way it is.

That still doesn't fix the "prev" and "next" images that are defined in lightbox.css. These should pop up on the lightbox image if there is more than one image posted in the msg. Will have to look into that one some more.

denney · Novice Joined: Dec 24, 2007 Posts: 28

Thanks for that. You can do that and it will work.

Only thing though, remember to move the CDATA script so that it appears AFTER the line that loads "lightbox.js". Took me half an hour to figure that out. Lol.

I never even realised the prev and next images were missing. I'll look into that as well.

denney · Novice Joined: Dec 24, 2007 Posts: 28

Well, to fix the "prev" and "next" images,

move the Gallery2 Javascript code in "template/overall_header.html" UP so that it comes before the

Code: › <link href="{T_THEME_PATH}/print.css" rel="stylesheet" type="text/css" media="print" title="printonly" />

line.

Then, edit "theme/buttons.css" and add the following to the END of the file:

Code: › #prevLink, #nextLink{
background: transparent url({ROOT_PATH}/g2image/images/blank.gif) no-repeat; /* Trick IE into showing hover */
}
#prevLink:hover, #prevLink:visited:hover { background: url({ROOT_PATH}/g2image/images/prevlabel.gif) left 15% no-repeat; }
#nextLink:hover, #nextLink:visited:hover { background: url({ROOT_PATH}/g2image/images/nextlabel.gif) right 15% no-repeat; }

I picked "buttons.css" because that seemed the most appropriate as the images are buttons in a way.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

Quote: › Only thing though, remember to move the CDATA script so that it appears AFTER the line that loads "lightbox.js". Took me half an hour to figure that out. Lol.

Yeah, sorry, it needs to be after loading lightbox.js so it can overwrite the values set by lightbox.js

Quote: › Well, to fix the "prev" and "next" images,

Nice! I'll try that out...thanks!

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 1144

jettyrat wrote: ›

Quote: › Well, to fix the "prev" and "next" images,

Nice! I'll try that out...thanks!

That works nicely, but only for prosilver.

What you have there works perfectly well, but for the integration package, I added a lightbox_overrides.css to both prosilver and subsilver2 and then added a line to overall_header.html to load the override file after lightbox.css is loaded. Only drawback with this is the paths are hard-coded in the override file, but that is the way subsilver's stylesheet.css file is anyway; it's not parsed like prosilver's style sheet.css, so things like {ROOT_PATH} don't work in subsilver2.

lightbox_overrides.css (in styles/xxxsilver/theme directory)

Code: › /* ********************************************************************************
* fix that allows prev and next buttons to show up on lightbox images
*/
#prevLink, #nextLink {
background: transparent url(../../../g2image/images/blank.gif) no-repeat; /* Trick IE into showing hover */
}

#prevLink:hover, #prevLink:visited:hover {
background: url(../../../g2image/images/prevlabel.gif) left 15% no-repeat;
}

#nextLink:hover, #nextLink:visited:hover {
background: url(../../../g2image/images/nextlabel.gif) right 15% no-repeat;
}

overall_header.html mod

Code: › <link rel="stylesheet" href="{ROOT_PATH}g2image/css/lightbox.css" type="text/css" media="screen" />
<link rel="stylesheet" type="text/css" href="{T_THEME_PATH}/lightbox_overrides.css" />

denney · Novice Joined: Dec 24, 2007 Posts: 28

As I have my gallery2.php file outside of my forum directory, I can't really do the hard coded paths thing.

I didn't realise that Subsilver doesn't have the CSS files parsed. How strange.

Oh well, I'm glad you could make some kind of change to fix this problem. Keep up the great work.

denney · Novice Joined: Dec 24, 2007 Posts: 28

Your way is actually better because one problem I just noticed was that, because I had the "g2embed_overrides.css" included before the style stylesheet it wasn't actually overriding anything and looked horrible! Smile

Web Hosting India