New code

spreck · Beginner Joined: Feb 28, 2008 Posts: 3

nice! i kept visiting this site waiting for a release into phpbb3 gold. than i just today stumbled onto this post. can't wait to try it out on my test forum. but i have a question.. what package should i download of gallery? typical, full, or minimal? or does it not matter?

can't wait for it's final release where i will install on my family forums. and gladly donate for all your hard work. Very Happy

AdBot

kaptainkory · Beginner Joined: Jan 31, 2006 Posts: 2

Could be me, but I've run into some problems with the latest 1.0.1 code:

1) I don't think the listed files to copy are everything necessary, are they?

Code: › File Copy
1. Copy: root/gallery2.php
To: gallery2.php
2. Copy: root/g2helper.php
To: g2helper.php
3. Copy: root/adm/G2EmbedDiscoveryUtilities.php
To: adm/G2EmbedDiscoveryUtilities.php
4. Copy: root/adm/style/acp_gallery2.html
To: adm/style/acp_gallery2.html
5. Copy: root/g2image/*.*
To: g2image/*.*
6. Copy: root/includes/acp/acp_gallery2.php
To: includes/acp/acp_gallery2.php
7. Copy: root/includes/acp/info/acp_gallery2.php
To: includes/acp/info/acp_gallery2.php

What about these?
* /root/language/en/mods/gallery2.php
* /root/styles/*.*

2) I went ahead and uploaded what I thought was missing from the instructions, but I still see "ACP_GALLERY2" when trying to install the module. Shouldn't this say something more human friendly? Seems like there is a miscue on linking to a language file somewhere. (Could be related to #4.)

3) When I try to synchronize users, it croaks on a user that has an apostrophe:

Code: › SQL ERROR [ mysql4 ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's' LIMIT 1' at line 3 [1064]

SQL

SELECT username FROM phpbb_users WHERE username = 'donni_down's' LIMIT 1

BACKTRACE

FILE: includes/db/mysql.php
LINE: 158
CALL: dbal_mysql->sql_error()

FILE: includes/db/mysql.php
LINE: 205
CALL: dbal_mysql->sql_query()

FILE: includes/db/dbal.php
LINE: 157
CALL: dbal_mysql->_sql_query_limit()

FILE: includes/acp/acp_gallery2.php
LINE: 611
CALL: dbal_mysql->sql_query_limit()

FILE: includes/functions_module.php
LINE: 471
CALL: acp_gallery2->main()

FILE: adm/index.php
LINE: 74
CALL: p_master->load_active()

4) When I access my members list, I see a bunch of this:

Code: › [phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT

5) Not so much an error as a frustration... When the automatic configuration set the gallery to strict embed mode, I was not happy being locked out of regular access to my gallery. (I don't have it set up for people to register through the gallery anyway, so that's a non issue.) I think it would be helpful to be a little more transparent on this and to provide instructions for someone to undo this if it is not what they want.

I appreciate your hard work on this. I've done my fair share of coding, too, and I know it is time-consuming and difficult. Unfortunately, I can't get far enough along to know what I even think of the actual integration.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 955

Please follow the instructions in the README and all your problems will disappear Wink

Except maybe the apostrophe issue, I'll have to look into that.

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 955

I'm not able to reproduce the apostrophe issue. Users with apostrophe's in their names work fine for me when exporting and when logging in to gallery from phpbb. And I have all magic quoting turned off on my server setup...

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 955

Ok, I can reproduce this on user synchronization when the user already exists in Gallery...

FILE: includes/acp/acp_gallery2.php
LINE: 611
Replace

Code: › WHERE username = '$name'";

With

Code: › WHERE username = '" . $db->sql_escape($name) . "'";

jettyrat · Moderator Joined: Nov 28, 2005 Posts: 955

Dari has released the official 1.0.1 version. Please start a new thread for any new issues...