Topic Title: New code

Forum Index » phpBB3 / Gallery 2 Integration » New code
Topic URL: http://www.nukedgallery.net/postt3884.html

AuthorMessage
Post Title: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Wed Feb 13, 2008 10:29 am
Dari has the next release version of the integration, but he is very busy and I don't know when he will be able to get an official version released.

For now, anyone wishing to get their fingers on the latest version (the same code that will be released), can get it here...
Gallery2_Integration-1.0.0.zip [jettyfishing.com]

AuthorMessage
Post Title: Re: New code
lanec
Joined: Feb 13, 2008
Posts: 1

Posted: Wed Feb 13, 2008 4:20 pm
Ouch... I just wasted a bunch of time integrating the old mod Sad

Thanks though! This one looks like it has some MAJOR installation improvements.

AuthorMessage
Post Title: Re: New code
firemists15
Joined: Feb 25, 2007
Posts: 9

Posted: Wed Feb 13, 2008 4:51 pm
I'm going to be trying this when I get home from work, I just spent half the day upgrading from G2 2.2.1 to 2.2.4 thinking maybe it was part of the problem

Will posts results later tonight Very Happy

I like the XML installs though makes things easier to follow, which may be my complete issue to start with

Very Happy

AuthorMessage
Post Title: Re: New code
darkxst
Joined: Mar 25, 2006
Posts: 10

Posted: Fri Feb 15, 2008 5:03 am
Well I have successfully installed the integration on my test site. Great work jettyrat this mod is very nice!

just a quick question, when I upgrade my website which is current running the phpBB2/g2 integration, do I need to copy the g2_user mappings in phpbb_user table across, or will the sync users function handle this for me?

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Fri Feb 15, 2008 10:43 am
I think you are asking about the gallery item id's that get assigned to the phpbb users as links to their albums...

The sync users function does not do this, it just makes sure user accounts in gallery and phpbb match each other. The album mapping happens when users visit gallery. Every time a logged in user visits gallery, the album mapping is checked. If a user has an album and does not have a link, one is created; if a user deletes their album and creates another one, the link is corrected; etc. So, eventually over time as users visit gallery, the users table will automatically update itself with the links. If you have a convenient way to update the table accurately, you could speed up the process. The only issue really is that when you do the upgrade, your users profiles and posts will not have the gallery link until they login and visit gallery.

AuthorMessage
Post Title: Re: New code
alitogata
Joined: Nov 06, 2007
Posts: 5

Posted: Tue Feb 19, 2008 8:59 pm
Firstly I want to thank you for this excellent integration. Actually I've been trying to integrate gallery with joomla but the bridge for joomla is not really supported any longer and in an effort to find a solution and since I changed from SMF to PHPBB I found out about galllery2&phpbb.

I must admin that installing mods in SMF was much easier but phpbb is way much better.

I have a question about this integration and one problem that I have using the New Code.

If there is a new version e.g. Gallery2_Integration-1.0.1 do I have to do all the process from the start?

Also I used the 1.0.0 Integration and I have the following problems:

In memberlist I get the following:



At the column that is titled Username (right of website) there it shows the link to the gallery. But how do I get rid of the rest of the columns on the right and make that column named to Gallery as the last column?

Also, are the members able to define any settings for the gallery link on their profile? e.g. how many photos, from which album if they have more than one etc..? Or disable this?

Other than that, I didn't have any other problems and it works great!!

Thank you

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Wed Feb 20, 2008 12:03 am
Quote: › If there is a new version e.g. Gallery2_Integration-1.0.1 do I have to do all the process from the start?

Upgrading from one integration version to the next is always a problem. There is no easy way except to go through the mods and look for the changes. If there is an easier way, I'm open to suggestions.

Quote: › In memberlist I get the following:

You are using the subsilver2 style? Double check the mods to the subsilver memberlist_body.html, something is wrong with your mods. That is not what it should look like.

Quote: › Also, are the members able to define any settings for the gallery link on their profile? e.g. how many photos, from which album if they have more than one etc..? Or disable this?

That is all controlled in the ACP under Gallery 2 Settings->Link Settings. Only the admin can turn it on or off and set how many images are displayed. There is currently no way to set which album the images come from. The integration just grabs them from the albums and displays them in sequential order until the max number is reached. If there are more, then a link is shown to the rest of the users gallery.

AuthorMessage
Post Title: Re: New code
alitogata
Joined: Nov 06, 2007
Posts: 5

Posted: Wed Feb 20, 2008 8:57 am
Thank you for your reply jettyrat.

Yes I am using subsilver2. It seems that indeed there is a problem in memberlist_body.html.

Might be somewhere at this code:


Code: ›    <th nowrap="nowrap" width="25%" align="{S_CONTENT_FLOW_BEGIN}"><a href="{U_SORT_USERNAME}">{L_USERNAME}</a></th>
   <th nowrap="nowrap" width="15%"><a href="{U_SORT_JOINED}">{L_JOINED}</a></th>
   <th nowrap="nowrap" width="10%"><a href="{U_SORT_POSTS}">{L_POSTS}</a></th>
   <th nowrap="nowrap" width="15%"><a href="{U_SORT_RANK}">{L_RANK}</a></th>
   <th nowrap="nowrap" width="11%">{L_SEND_MESSAGE}</th>
   <th nowrap="nowrap" width="11%"><a href="{U_SORT_EMAIL}">{L_EMAIL}</a></th>
   <th nowrap="nowrap" width="11%"><a href="{U_SORT_WEBSITE}">{L_WEBSITE}</a></th>


In xml instructions for subsilver2 it says to add after the above the lines mentioned in the instructions. But if I replace the above lines with the ones in the instructions that I added it shows correctly. Might be this? I am not good with codes etc... but I delete the above lines and the member list looks good now.

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Wed Feb 20, 2008 10:24 am
Quote: › In xml instructions for subsilver2 it says to add after the above the lines mentioned in the instructions. But if I replace the above lines with the ones in the instructions that I added it shows correctly. Might be this? I am not good with codes etc... but I delete the above lines and the member list looks good now.

Ah, you probably found a bug in the xml...I just converted to xml a short while ago. The instructions should probably say 'replace with' instead of 'after-add'. I'll check it out. Thanks for the report!

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Wed Feb 20, 2008 10:50 am
Yep, my bad...the mod instruction should say 'replace-with'. What you have done to fix it was the right thing...

AuthorMessage
Post Title: Re: New code
alitogata
Joined: Nov 06, 2007
Posts: 5

Posted: Mon Feb 25, 2008 9:18 pm
jettyrat a big THANK YOU for this integration. It's the best I ever used. Although I am unemployed at the moment and can't donate anything, as soon I find a job I'll be sure donating for this excellent integration.

AuthorMessage
Post Title: Re: New code
darkxst
Joined: Mar 25, 2006
Posts: 10

Posted: Tue Feb 26, 2008 2:49 am
Quote: › There is currently no way to set which album the images come from. The integration just grabs them from the albums and displays them in sequential order until the max number is reached. If there are more, then a link is shown to the rest of the users gallery.


Would it be possible to randomly select the images to display in the profile?

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Tue Feb 26, 2008 10:13 am
The next feature on my list of things to add to the integration is a UCP page that would allow the user to select the items shown, whether albums or photos are shown, the number to show (up to the limit set by admin) and pick an image to use as their avatar. A random option could be possible as well.

The mapAllGalleryLinks function grabs all the users items, then slices off the number it needs. You could add some random selection code there if you wanted. I personally would rather work on the UCP option as I think it is more useful.

Another way to get certain items shown that you want is to re-order them in Gallery so they are the first ones that get grabbed by the integration code.

AuthorMessage
Post Title: Re: New code
darkxst
Joined: Mar 25, 2006
Posts: 10

Posted: Tue Feb 26, 2008 3:33 pm
jettyrat wrote: › The next feature on my list of things to add to the integration is a UCP page that would allow the user to select the items shown, whether albums or photos are shown, the number to show (up to the limit set by admin) and pick an image to use as their avatar. A random option could be possible as well.


Yeh that would be good, much more useful than the current situation!

AuthorMessage
Post Title: Re: New code
sypher01
Joined: Feb 05, 2008
Posts: 19

Posted: Thu Feb 28, 2008 3:36 pm
link down? Sad

just tried, here it is. this works.

http://jettyfishing.com/tmp/Gallery2_In ... -1.0.1.zip

AuthorMessage
Post Title: Re: New code
spreck
Joined: Feb 28, 2008
Posts: 3

Posted: Fri Feb 29, 2008 8:10 pm
nice! i kept visiting this site waiting for a release into phpbb3 gold. than i just today stumbled onto this post. can't wait to try it out on my test forum. but i have a question.. what package should i download of gallery? typical, full, or minimal? or does it not matter?

can't wait for it's final release where i will install on my family forums. and gladly donate for all your hard work. Very Happy

AuthorMessage
Post Title: Re: New code
kaptainkory
Joined: Jan 31, 2006
Posts: 2

Posted: Sat Mar 01, 2008 12:51 am
Could be me, but I've run into some problems with the latest 1.0.1 code:

1) I don't think the listed files to copy are everything necessary, are they?

Code: › File Copy
   1. Copy: root/gallery2.php
          To: gallery2.php
   2. Copy: root/g2helper.php
          To: g2helper.php
   3. Copy: root/adm/G2EmbedDiscoveryUtilities.php
          To: adm/G2EmbedDiscoveryUtilities.php
   4. Copy: root/adm/style/acp_gallery2.html
          To: adm/style/acp_gallery2.html
   5. Copy: root/g2image/*.*
          To: g2image/*.*
   6. Copy: root/includes/acp/acp_gallery2.php
          To: includes/acp/acp_gallery2.php
   7. Copy: root/includes/acp/info/acp_gallery2.php
          To: includes/acp/info/acp_gallery2.php


What about these?
* /root/language/en/mods/gallery2.php
* /root/styles/*.*

2) I went ahead and uploaded what I thought was missing from the instructions, but I still see "ACP_GALLERY2" when trying to install the module. Shouldn't this say something more human friendly? Seems like there is a miscue on linking to a language file somewhere. (Could be related to #4.)

3) When I try to synchronize users, it croaks on a user that has an apostrophe:
Code: › SQL ERROR [ mysql4 ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's' LIMIT 1' at line 3 [1064]

SQL

SELECT username FROM phpbb_users WHERE username = 'donni_down's' LIMIT 1

BACKTRACE

FILE: includes/db/mysql.php
LINE: 158
CALL: dbal_mysql->sql_error()

FILE: includes/db/mysql.php
LINE: 205
CALL: dbal_mysql->sql_query()

FILE: includes/db/dbal.php
LINE: 157
CALL: dbal_mysql->_sql_query_limit()

FILE: includes/acp/acp_gallery2.php
LINE: 611
CALL: dbal_mysql->sql_query_limit()

FILE: includes/functions_module.php
LINE: 471
CALL: acp_gallery2->main()

FILE: adm/index.php
LINE: 74
CALL: p_master->load_active()


4) When I access my members list, I see a bunch of this:

Code: › [phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1613: Undefined index: GALLERY_LINK
[phpBB Debug] PHP Notice: in file /memberlist.php on line 1614: Undefined index: GALLERY_VISIT


5) Not so much an error as a frustration... When the automatic configuration set the gallery to strict embed mode, I was not happy being locked out of regular access to my gallery. (I don't have it set up for people to register through the gallery anyway, so that's a non issue.) I think it would be helpful to be a little more transparent on this and to provide instructions for someone to undo this if it is not what they want.

I appreciate your hard work on this. I've done my fair share of coding, too, and I know it is time-consuming and difficult. Unfortunately, I can't get far enough along to know what I even think of the actual integration.

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Mon Mar 03, 2008 12:49 am
Please follow the instructions in the README and all your problems will disappear Wink
Except maybe the apostrophe issue, I'll have to look into that.

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Mon Mar 03, 2008 11:03 am
I'm not able to reproduce the apostrophe issue. Users with apostrophe's in their names work fine for me when exporting and when logging in to gallery from phpbb. And I have all magic quoting turned off on my server setup...

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Mon Mar 03, 2008 12:55 pm
Ok, I can reproduce this on user synchronization when the user already exists in Gallery...

FILE: includes/acp/acp_gallery2.php
LINE: 611
Replace
Code: ›                      WHERE username = '$name'";

With
Code: ›                      WHERE username = '" . $db->sql_escape($name) . "'";

AuthorMessage
Post Title: Re: New code
jettyrat
Joined: Nov 28, 2005
Posts: 1144

Posted: Mon Mar 03, 2008 5:50 pm
Dari has released the official 1.0.1 version. Please start a new thread for any new issues...

All times are GMT - 5 Hours
Powered by PHPNuke and phpBB2 © 2006 phpBB Group