Topic Title: Sorry...been busy

Forum Index » phpBB3 / Gallery 2 Integration » Sorry...been busy
Topic URL: http://www.nukedgallery.net/postt3735.html

AuthorMessage
Post Title: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Fri Oct 12, 2007 4:52 pm
Sorry I've been away for so long. Changed jobs twice, moved twice, got two kids in college, blah blah blah. Been hard to find time to get motivated to work on this, but now things are a little more settled down.

I'll get the latest versions of gallery and phpbb3 this weekend and work through the integration. I'm encouraged that it won't be too difficult since others have been able to make it work on their own. Will see how far I can get on fixing it up over the weekend.

AuthorMessage
Post Title: Re: Sorry...been busy
timnsal
Joined: Aug 08, 2007
Posts: 20
Posted: Sat Oct 13, 2007 4:28 am
phpBB are predicting that the next RC will break a lot of existing mods. Pity they don't give any indication on how soon it will be out.

I'm sure you won't have too much problem with the integration. Hope you can do the bit I couldn't get to work Embarassed

Sally

AuthorMessage
Post Title: Re: Sorry...been busy
mrmikehammond
Joined: Jun 12, 2007
Posts: 21
Location: U.K.
Posted: Sun Oct 14, 2007 6:21 am
Superb , good to see you back Cool Cool

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Sun Oct 14, 2007 2:20 pm
OK....on to rc6. I waded through the majority of the integration and went to the phpbb admin panel and first thing it tells me is my board is out of date. Confused

Oh well. Biggest problem looks like it's going to be the prosilver changes

AuthorMessage
Post Title: Re: Sorry...been busy
timnsal
Joined: Aug 08, 2007
Posts: 20
Posted: Mon Oct 15, 2007 2:46 am
If it saves re-inventing the wheel, I've done the changes for prosilver for my board. You're welcome to a copy.

There weren't many changes going from rc5 to 6

Sally

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Tue Oct 16, 2007 12:23 am
Wow, spent the last couple hours trying to figure out why I couldn't see the integration configuration panels in the phpbb3 acp only to just now find out this has been reported already for firefox, which is what I use. The problem is the opening comment tag which contains the gallery legal blurb, etc. For some reason this throws off the css interpretation in firefox. I thought this was a prosilver css issue at first, but turns out to be a case of simply deleting this initial tag and it works just fine. (You'll notice none of the phpbb templates have any kind of phpbb blurb at the beginning.)

So...the majority of the integration works without too much problem. The remaining issues are with memberlist, view profile and view topic, mostly because of significant code and template changes. However these mods are not required for a successful core integration and are things I added later on in the phpbb2 integration development. Going to take a little longer than I thought to get all of this working, maybe a week or so to get things ironed out and back on track.

And, yeah the integration is ugly. I won't even go into how many times the stupid font size has changed in phpbb2 and phpbb3. Will figure out how to fix it along the way. Wink

Sally - if you've already addressed some of these issues and wish to collaborate I'll pm you my email address. May speed things up a bit. I would rather work in php than css any day!

AuthorMessage
Post Title: Re: Sorry...been busy
mrmikehammond
Joined: Jun 12, 2007
Posts: 21
Location: U.K.
Posted: Tue Oct 16, 2007 4:40 pm
Hate to tell you guys RC7 is out already ! Shocked looks like the dev team found a critical error in the RC6 update Mad


Mike Cool

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Tue Oct 16, 2007 5:04 pm
Yeah RC7 is what I'm using. The phpbb3 releases have gone at a snails pace for years and the weekend I want to work on it 2 releases come out in a matter of days...go figure!

AuthorMessage
Post Title: Re: Sorry...been busy
mrmikehammond
Joined: Jun 12, 2007
Posts: 21
Location: U.K.
Posted: Tue Oct 16, 2007 5:18 pm
jettyrat wrote: › Yeah RC7 is what I'm using. The phpbb3 releases have gone at a snails pace for years and the weekend I want to work on it 2 releases come out in a matter of days...go figure!



LOL I've been sitting on RC4 for a while now thinking I'll leave things for a couple of releases while it's stable with my portal and other tweaks then just when I decide to look at upgrading they spring another RC on us in no time .......arrrghhhh Mad

Oh well, lets hope they're getting closer to settling down Wink

Mike Cool

AuthorMessage
Post Title: Re: Sorry...been busy
timnsal
Joined: Aug 08, 2007
Posts: 20
Posted: Wed Oct 17, 2007 7:17 am
Well, they've done the security audit now, so it might be getting there. Last weekend was tricky because it was clear from comments on their forum that the update would be soon, but not clear enough to be sure it would be then.

I installed all my mods on a fresh install for RC6 and the updater fouled them up completely, so I've done them all again on RC7 Evil or Very Mad

Jettyrat, the integration looks a lot better in prosilver. I just tried switching to subsiver2 - yeuch.

Memberlist - I've got it with a gallery2 icon to click and take you to the person's gallery
Viewtopic - do you mean the image selector - that took me ages, but it seems to work.

Profile - got as far as working where the problem was, but couldn't sort that one out. The g2helper file was calling something from gallery2 and getting an empty result.

Jettyrat, I'll PM you my email address.

Sally

AuthorMessage
Post Title: Re: Sorry...been busy
timnsal
Joined: Aug 08, 2007
Posts: 20
Posted: Wed Oct 17, 2007 7:38 am
jettyrat wrote: › Wow, spent the last couple hours trying to figure out why I couldn't see the integration configuration panels in the phpbb3 acp only to just now find out this has been reported already for firefox, which is what I use. The problem is the opening comment tag which contains the gallery legal blurb, etc. For some reason this throws off the css interpretation in firefox. I thought this was a prosilver css issue at first, but turns out to be a case of simply deleting this initial tag and it works just fine. (You'll notice none of the phpbb templates have any kind of phpbb blurb at the beginning.)


You could try putting the blurb after the initial
Code: › <!-- INCLUDE overall_header.html --> 

It confuses the css in IE too, but it just makes the font size too large.
(I copied from a mod by Highway of Life Embarassed )[/quote]

Edit - Same trick works for making the main gallery page look ok Very Happy

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Thu Oct 18, 2007 5:38 pm
Sally, your integration looks great! Nice job - really, congrats on figuring it out on your own! I have your email, I'll be in touch eventually. I want to plug away on it a little more first so I can understand the changes better. I have it all working now except the memberlist view and the image selector. Just haven't got to those yet.

Here's a fix [nukedgallery.net] for the view profile problem in g2helper.inc

AuthorMessage
Post Title: Re: Sorry...been busy
timnsal
Joined: Aug 08, 2007
Posts: 20
Posted: Fri Oct 19, 2007 2:44 am
Thanks Smile I'll put that in.

Double host data - almost the last line of functions.js in the g2image jscripts folder - take out the http://

No images - I got that first when I was using a minimum install of gallery2 which didn't have imageblock installed (and took an embarrassingly long time to figure it out) Then I couldn't get the images into phpbb3 - found somewhere where 'post' had to be replaced with 'postform' Embarassed

Discovered I have a problem with the group synchronisation on mine. Haven't really looked into it yet.

Edit: Have now investigated and the only bit of the group synchronisation that works is creating groups when you synchronise users from the ACP. It doesn't add users to gallery2 groups in the synchronisation, or when they are added to phpbb groups, or delete them from groups when they are deleted from phpbb groups.

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Fri Oct 19, 2007 10:08 am
Thanks Sally. Your help is appreciated. I found the postform change right away as I had a suspicion that something like that had changed. I also changed the js function last night, but nothing changed during my testing...probably a cache issue...will work on it again today. You're probably right about the imageblock. One of my test machines has a full gallery install and the other has a minimum install...will check that out. Shouldn't take much to finish up the basic integration.

Left to do:
1. Check out and test all the functions (Sally has already discovered some issues - need to examine the data being passed)
2. Rewrite the installation procedures (clarify the imageblock issue, for one)
3. New gallery button to match the prosilver style
4. Rework some of the css in the templates and stylesheets to match the prosilver style better
5. Probably others that escape me at the moment

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Fri Oct 19, 2007 10:36 am
Noticed some css issues in gallery. Here's one example...there a lot of cases like this with the integrated gallery.



Will try moving the css links around in the overall_header and see if that helps Confused
Also there is a line like this in the phpbb head section calling a stylesheet that doesn't seem right
Code: › <link href="./styles/prosilver/theme/print.css" rel="stylesheet" type="text/css" media="print" title="printonly" />
<link href="./style.php?sid=cc8839d32153c902cc3252e3645c0743&amp;id=1&amp;lang=en" rel="stylesheet" type="text/css" media="screen, projection" />

Maybe I just don't understand what it is supposed to do, but the second line doesn't look right to me...

edit - moving the order of the css link calls does not help anything. More css issues.... Evil or Very Mad
The problem mostly appears to be related to form check boxes...

AuthorMessage
Post Title: Re: Sorry...been busy
timnsal
Joined: Aug 08, 2007
Posts: 20
Posted: Fri Oct 19, 2007 11:45 am
I've been trying to ignore those Embarassed and I'm giving up on the groups thing for now. It seems to be when it tries to call IsExternalIdMapped and it wasn't, so it returns null and then nothing else happens.

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Fri Oct 19, 2007 11:38 pm
I got the group create and group delete functions working now...one change to the mod instructions and a few changes to g2helper.inc...

There hasn't been much interest in this integration until now, so as you can tell, everything hasn't been tested very well Embarassed

Making good progress now though!

AuthorMessage
Post Title: Re: Sorry...been busy
jettyrat
Joined: Nov 28, 2005
Posts: 1144
Posted: Fri Oct 19, 2007 11:48 pm
This change to the mod instructions to includes/functions_user.php (was after, add)
Code: › #
#-----[ FIND ]------------------------------------------
#
   // Delete group
   $sql = 'DELETE FROM ' . GROUPS_TABLE . "
      WHERE group_id = $group_id";
   $db->sql_query($sql);

#
#-----[ BEFORE, ADD ]------------------------------------------
#
   // Delete group in Gallery
   require($phpbb_root_path . 'g2helper.inc');
   $g2h = new g2helper($db);
   $g2h->deleteGroup($group_id);


Replace these functions in g2helper.inc
Code: ›    function createGroup($groupName) {
      global $user;

      $this->_initAdmin();

      $ret = GalleryEmbed::isExternalIdMapped($groupName, 'GalleryGroup');
      if (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
         $ret = GalleryEmbed::createGroup($groupName, $groupName);
         if (isset($ret)) {
            msg_handler(E_G2_ERROR, sprintf($user->lang['G2_CREATEGROUP_FAILED'], $groupName) . $user->lang['G2_ERROR'] . $ret->getAsHtml(), __FILE__, __LINE__);
         }
      }
      elseif (empty($ret)) {
         /*
         * Group already exists in gallery, so do nothing!
         */
      }
      else {
         msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $groupName), __FILE__, __LINE__);
      }

      $this->done();
   }

   function updateGroup($group_id, $newGroupName) {
      global $db, $user;

      $this->_initAdmin();

      $sql = 'SELECT group_name FROM ' . GROUPS_TABLE . " WHERE group_id = $group_id";
      if (!$row = $db->sql_fetchrow($db->sql_query_limit($sql, 1))) {
         msg_handler(E_G2_ERROR, $user->lang['FETCH_GROUPDATA_FAILED'], __FILE__, __LINE__);
      }

      $ret = GalleryEmbed::isExternalIdMapped($row['group_name'], 'GalleryGroup');
      if (empty($ret)) {
         $ret = GalleryEmbed::updateGroup($row['group_name'], array('groupname' => $newGroupName));
         if (isset($ret)) {
            msg_handler(E_G2_ERROR, sprintf($user->lang['G2_UPDATEGROUP_FAILED'], $newGroupName) . $user->lang['G2_ERROR'] . $ret->getAsHtml(), __FILE__, __LINE__);
         }

         $ret = GalleryCoreApi::updateMapEntry('ExternalIdMap', array('externalId' => $row['group_name']) , array('externalId' => $newGroupName));
         if (isset($ret)) {
            msg_handler(E_G2_ERROR, sprintf($user->lang['G2_UPDATEMAPENTRY_FAILED'], $row['group_name']) . $user->lang['G2_ERROR'] . $ret->getAsHtml(), __FILE__, __LINE__);
         }
      }
      elseif (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
         /*
         * Group does not exist in gallery, so do nothing!
         */
      }
      else {
         msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $row['group_name']), __FILE__, __LINE__);
      }

      $this->done();
   }

   function deleteGroup($groupId) {
      global $db, $user;

      $this->_initAdmin();

      $sql = 'SELECT group_name FROM ' . GROUPS_TABLE . "   WHERE group_id = $groupId";
      if (!$row = $db->sql_fetchrow($db->sql_query_limit($sql, 1))) {
         msg_handler(E_G2_ERROR, $user->lang['FETCH_GROUPDATA_FAILED'], __FILE__, __LINE__);
      }

      $ret = GalleryEmbed::isExternalIdMapped($row['group_name'], 'GalleryGroup');
      if (empty($ret)) {
         $ret = GalleryEmbed::deleteGroup($row['group_name']);
         if (isset($ret)) {
            msg_handler(E_G2_ERROR, sprintf($user->lang['G2_DELETEGROUP_FAILED'], $row['group_name']) . $user->lang['G2_ERROR'] . $ret->getAsHtml(), __FILE__, __LINE__);
         }
      }
      elseif (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
         /*
         * Group does not exist in gallery, so do nothing!
         */
      }
      else {
         msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $row['group_name']), __FILE__, __LINE__);
      }

      $this->done();
   }

   function addUserToGroup($members, $groupId) {
      global $db, $user;

      $this->_initAdmin();

      $sql = 'SELECT group_name FROM ' . GROUPS_TABLE . " WHERE group_id = $groupId";
      if (!$row = $db->sql_fetchrow($db->sql_query_limit($sql, 1))) {
         msg_handler(E_G2_ERROR, $user->lang['FETCH_GROUPDATA_FAILED'], __FILE__, __LINE__);
      }

      $ret = GalleryEmbed::isExternalIdMapped($row['group_name'], 'GalleryGroup');
      if (empty($ret)) {
         $id[] = explode(', ', $members);

         for ($i = 0; $i < count($id); $i++) {
            $ret = GalleryEmbed::isExternalIdMapped($id[$i][0], 'GalleryUser');
            if (empty($ret)) {
               $ret = GalleryEmbed::addUserToGroup($id[$i][0], $row['group_name']);
               if (isset($ret)) {
                  msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ADDUSERTOGROUP_FAILED'], $row['group_name'], $id[$i][0]) . $user->lang['G2_ERROR'] . $ret->getAsHtml(), __FILE__, __LINE__);
               }
            }
            elseif (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
               /*
               * User does not exist in gallery, so do nothing!
               */
            }
            else {
               msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $id[$i][0]), __FILE__, __LINE__);
            }
         }
      }
      elseif (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
         /*
         * Group does not exist in gallery, so do nothing!
         */
      }
      else {
         msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $row['group_name']), __FILE__, __LINE__);
      }

      $this->done();
   }

   function removeUserFromGroup($members, $groupId) {
      global $db, $user;

      $this->_initAdmin();

      $sql = 'SELECT group_name FROM ' . GROUPS_TABLE . " WHERE group_id = $groupId";
      if (!$row = $db->sql_fetchrow($db->sql_query_limit($sql, 1))) {
         msg_handler(E_G2_ERROR, $user->lang['FETCH_GROUPDATA_FAILED'], __FILE__, __LINE__);
      }

      $ret = GalleryEmbed::isExternalIdMapped($row['group_name'], 'GalleryGroup');
      if (empty($ret)) {
         $id[] = explode(', ', $members);

         for ($i = 0; $i < count($id); $i++) {
            $ret = GalleryEmbed::isExternalIdMapped($id[$i][0], 'GalleryUser');
            if (empty($ret)) {
               $ret = GalleryEmbed::removeUserFromGroup($id[$i][0], $row['group_name']);
               if (isset($ret)) {
                  msg_handler(E_G2_ERROR, sprintf($user->lang['G2_REMOVEUSERFROMGROUP_FAILED'], $groupId, $id[$i][0]) . $user->lang['G2_ERROR'] . $ret->getAsHtml(), __FILE__, __LINE__);
               }
            }
            elseif (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
               /*
               * User does not exist in gallery, so do nothing!
               */
            }
            else {
               msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $id[$i][0]), __FILE__, __LINE__);
            }
         }
      }
      elseif (isset($ret) && $ret->getErrorCode() & ERROR_MISSING_OBJECT) {
         /*
         * Group does not exist in gallery, so do nothing!
         */
      }
      else {
         msg_handler(E_G2_ERROR, sprintf($user->lang['G2_ISEXTERNALIDMAPPED_FAILED'], $row['group_name']), __FILE__, __LINE__);
      }

      $this->done();
   }

All times are GMT - 5 Hours
Powered by PHPNuke and phpBB2 © 2006 phpBB Group